Closed XD-DENG closed 4 years ago
Of course everything would work fine if we have configuration file
[cosmic-ray.filters.operators-filter]
exclude-operators = [ ... ]
instead of (what is suggested in doc now)
[cosmic-ray.operators-filter]
exclude-operators = [ ... ]
Hence we should either change the code or "correct" the documentation. Otherwise it's really confusing to users.
Any preference?
Thanks for pointing this out!
The correct configuration key is:
[cosmic-ray.filters.operators-filter]
The reason is that the notion of "filter" covers a lot of functionality and different programs. So my plan is to have the "filter" key contain configuration for all filter programs.
I'll make the necessary changes to the documentation, and I'll close this PR without merging it. Thanks again!
Thanks @abingham for the clarification. Definitely reasonable to me.
Cheers!
I may be wrong, but based on
here we should have
config.sub('operators-filter')
rather thanconfig.sub('filters', 'operators-filter')
.Code to Reproduce & Check
If I save the sample configuration TOML in the documentation as
config.toml
, then I run code belowI got
{}
.Instead, if I change to
I got expected result