Issue #23, fixed failing test_ceil and test_floor in test_float

sixty-north / segpy

A Python package for reading and writing SEG Y files.

Other

102 stars 54 forks source link

Issue #23, fixed failing test_ceil and test_floor in test_float #24

Closed kjellkongsvik closed 9 years ago

kjellkongsvik commented 9 years ago

Change the way supplied floats are generated. Interval should not be (0.0,1,0). It should be (eps,1.0-eps). Then the assumption f!=1.0 can be removed

rob-smallshire commented 9 years ago

Hi,

Can you explain why you have closed your pull request? I hadn't got around to assessing/responding/merging just. Is this PR still relevant?

kjellkongsvik commented 9 years ago

Hi,

Still relevant. Guessed the CLA needs to be signed before PR.

rob-smallshire commented 9 years ago

Yes, we do need a CLA from you before merging your PR. I know this seems like a pain – and really we are grateful for your contribution – but it's important to us that we keep the copyright structure simple.