search

sixty-north / segpy

A Python package for reading and writing SEG Y files.
Other
102 stars 54 forks source link

Implement IBM float in C++ #33

Closed abingham closed 7 years ago

abingham commented 7 years ago

This would almost certainly add a significant speed boost, and maybe some space savings as well. Of course this complicates the deployment/distribution story, so it might be good to keep the existing Python implementation around as a fall-back, i.e. for people who can't build C++ extensions.

abingham commented 7 years ago

This is supported as of 3e9d106d1b0bbe3d805ef07542d1fc8d3817b3d6.

The C++ implementation is actually in a separate package. The main change to segpy is that it will use that extension if it's installed. If the extension is not installed then segpy will fall back to the Python implementations. Likewise, the user can explicitly force segpy to use the Python version if they want (though I expect that this is mostly just useful for testing).