siyuan-note / siyuan

A privacy-first, self-hosted, fully open source personal knowledge management software, written in typescript and golang.
https://b3log.org/siyuan
GNU Affero General Public License v3.0
21.72k stars 1.56k forks source link

Performance Improvement Needed for Toggle Block: Loading Indicator Causes Delays #12986

Closed itszarnish closed 14 hours ago

itszarnish commented 21 hours ago

Is there an existing issue for this?

Can the issue be reproduced with the default theme (daylight/midnight)?

Could the issue be due to extensions?

Describe the problem

I've noticed that the performance of the toggle block is not smooth and doesn't feel robust to me. It shows a loading indicator whenever I toggle to display the content, which I have never seen in any other PKMs.

Here are the video recordings demonstrating the toggle feature:

1. SiYuan Toggle Feature:

https://github.com/user-attachments/assets/434fa91a-7d5f-4c31-a1ea-cb268fe26728

image

2. Toggle Feature in Capacities (feels smooth and fast without a loading indicator):

image

https://github.com/user-attachments/assets/bdbf29a6-b3aa-4213-9812-5d294cc1f554

3. Toggle Feature in AnyType (also fast):

image

https://github.com/user-attachments/assets/c06b5f3a-91c5-4562-9385-adfa2892f4e0

Additionally, it would be better to have a dedicated toggle block. As you can see in both Capacities and AnyType, the arrow icon is displayed properly, whereas in SiYuan, the arrow icon only appears when the user hovers over it. This can be improved.

Screenshot or screen recording presentation

No response

Version environment

- Version: 
- Operating System: 
- Browser (if used):

Log file

-

More information

No response

88250 commented 14 hours ago

This cannot be improved, because the heading block needs to be dynamically calculated and loaded.

itszarnish commented 3 hours ago

Okay, what I mean is: is it impossible to improve, or is it just that you don’t have the time for it? If that's the case, I would request that you please don’t close this issue, as it’s really important. Take your time, and maybe consider improving it in the coming weeks or months, but please do something about it. The current implementation of the toggle feels slow and at least do something about that loading indicator doesn't look good at all. Thank you.

HamXaY09 commented 14 minutes ago

+1 I've also noticed this issue.