siyuanliii / masa

Official Implementation of CVPR24 highligt paper: Matching Anything by Segmenting Anything
https://matchinganything.github.io
Apache License 2.0
964 stars 62 forks source link

Would you consider supporting the YOLOv8-p2 model? #14

Closed Fiorentinar closed 3 months ago

Fiorentinar commented 3 months ago

Thanks for your excellent work!

I noticed that the MASA config does not include the latest YOLO networks (YOLOv8-v10).

May I ask if you are considering supporting the YOLOv8-p2 model? Or can you support the standard YOLOv8 model?

siyuanliii commented 3 months ago

Thanks a lot for your interest! MASA can directly support all detectors in mmdetection. It seems YOLOv8-p2 is not included in mmdetection yet. However, it should be simple to add it in the demo file by yourself. You just need to replace the bounding boxes input to the output of YOLOv8 detector. I will also try to include it in the next phase update.

Fiorentinar commented 3 months ago

Thank you for your response. My understanding of the mmdetection framework is not deep enough, but I will try to write the config for it. Thank you for your help.

gurkirt commented 3 months ago

@siyuanliii @Fiorentinar, I am able to run yolov10 which is based on yolov8. If you want I can do a PR?

Fiorentinar commented 3 months ago

@gurkirt Thank you very much for your contribution, but this requires the author's consent @siyuanliii.

siyuanliii commented 3 months ago

Thank you very much! Please feel free to add PRs. I will review all PRs later and merge them.