Closed gustavdelius closed 11 months ago
The length-based parameters are now removed once they have been used to calculate any missing weight-based parameters
It was not a good idea to remove the length-based parameters. Users may really want to keep a record of what parameters they have provided. Also they may have added comments to the parameters that they want to preserve.
To avoid the frequent warning, I have converted it to a signal instead, so it will be issued when creating a new model but not each time the model is changed.
If a species parameter has both an
l_mat
and aw_mat
column, then each time mizer checks the validity of the species parameters (which it does each time a species parameter is changed) it issues a warning if thel_mat
andw_mat
values are inconsistent with each other. This will be a nuisance when the user has made a conscious decision to changew_mat
(for example while usingtuneParams()
) but does not want to have to changel_mat
by hand at the same time.There are two possible solutions:
1) Delete the
l_mat
column once there is anw_mat
column 2) Recalculate thel_mat
column each timew_mat
is changed and similarly recalculatew_mat
whenl_mat
is changed.I am in favour of the first solution.