sizmailov / pybind11-stubgen

Generate stubs for python modules
Other
232 stars 47 forks source link

Fix module imports for properties #82

Closed brentyi closed 1 year ago

brentyi commented 2 years ago

Currently, property signatures are not considered when determining module imports. Just added a few lines that fixes that. :slightly_smiling_face:

sizmailov commented 2 years ago

Thanks for the contribution! The change looks good to me. Do you mind adding a test that reveals the issue? If not, it's ok, I'll add it later myself.

brentyi commented 2 years ago

If it's quick for you I'd appreciate help!

Happy to do it, but crunched for time right now and won't be able to get to it for at least a few weeks.

sizmailov commented 1 year ago

Superceeded by #112