search

siznax / moo

🎷 Your music in your browser
MIT License
2 stars 2 forks source link

lib.info should be lib.album or lib.album_info #15

Closed siznax closed 3 years ago

siznax commented 3 years ago

"info" is simply too generic. This information should line up with album in our code reference https://github.com/siznax/moo/wiki/%F0%9F%8E%B7-Reference

khafrewatkins commented 3 years ago

Hi, can you give a little more detail on what you want done? The descriptions do look generic as you described it.

siznax commented 3 years ago

Thanks for posting, @khafrewatkins. This is "simply" a name change.

We need to change lib.info() to lib.album() in https://github.com/siznax/moo/blob/main/Moo/play/lib.py

lib.album() already exists, but it is not being used. So, here are the steps:

  1. Delete the lib.album() function
  2. Rename lib.info() to lib.album()
  3. Replace lib.info() with lib.album() in the rest of the code
  4. Replace the variable name info with album_info where applicable

Now that I've listed the steps, I realize this may not be a good first issue?

khafrewatkins commented 3 years ago

Hi, this is perfect! I can handle this. Thank you so much!

Khafre

On Mon, Mar 1, 2021, 11:12 AM Steve notifications@github.com wrote:

Thanks for posting, @khafrewatkins https://github.com/khafrewatkins. This is "simply" a name change.

We need to change lib.info() to lib.album() in https://github.com/siznax/moo/blob/main/Moo/play/lib.py

lib.album() already exists, but it is not being used. So, here are the steps:

  1. Delete the lib.album() function
  2. Rename lib.info() to lib.album()
  3. Replace lib.info() with lib.album() in the rest of the code
  4. Change the variable name info with album_info where applicable

Now that I've listed the steps, I realize this may not be a good first issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/siznax/moo/issues/15#issuecomment-788116980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHF2ONAWVR5MBFOFGSL752LTBPDHXANCNFSM4YLL3EZQ .