sizzlelab / side

t3rc
6 stars 3 forks source link

Sessions without measurement shouldn't be created #48

Closed mataanin closed 12 years ago

mataanin commented 12 years ago

Mostly applies to Vital parameters, as we will always have the accelerometer data.

mataanin commented 12 years ago

Miyula, please, verify it.

miyula commented 12 years ago

For heat beat, when Pulse is 0, a notice is showed on chart 'Pulse is 0, charge the meter or put i closer to body!', but the session is still created. And it can be selected to upload.

mataanin commented 12 years ago

Hm. Didn't plan to change this, as even if we don't have any pulse data, we record accelerometer.

What do you think?

On Mon, Nov 21, 2011 at 11:13 AM, Shuyan Zeng < reply@reply.github.com

wrote:

For heat beat, when Pulse is 0, a notice is showed on chart 'Pulse is 0, charge the meter or put i closer to body!', but the session is still created. And it can be selected to upload.


Reply to this email directly or view it on GitHub: https://github.com/sizzlelab/side/issues/48#issuecomment-2812936

miyula commented 12 years ago

For vital parameters, when I click, the mobile automatically connect with Fora, when go back it release the connection (I like it).

But every time I click the Vital Parameters, although there is no new measurement data is collected, a new session is created.

According to the uploading data file, it happens like this way:

  1. When click Vital Parameters, if a new blood pressure data is gotten by mobile, a new session with blood pressure and pulse is created (this part works well).
  2. After the first step, if I click Vital Parameter again, there is not any new blood pressure data or pulse. but a new session with the previous pulse data in step2 (no blood pressure) is created.

Every time I click Vital Parameter, a new session is created no matter there is new data or not

miyula commented 12 years ago

En, I agree with you about the accelerometer part. but for blood pressure, I suggest when click Vital parameters, if there is not any new data, show a message to user. And don't ceate new session.

mataanin commented 12 years ago

This is problem. It is going to be fixed. Estimate: 2 hours. Deadline: 27th

On Mon, Nov 21, 2011 at 11:56 AM, Shuyan Zeng < reply@reply.github.com

wrote:

En, I agree with you about the accelerometer part. but for blood pressure, I suggest when click Vital parameters, if there is not any new data, show a message to user. And don't ceate new session.


Reply to this email directly or view it on GitHub: https://github.com/sizzlelab/side/issues/48#issuecomment-2813342

katuta commented 12 years ago

Max, can I reassign this issue to you, since, I was told that I need to check the database, to see if the session was created or not. I think for you it will be easier.

mataanin commented 12 years ago

@katuta you can check if session has been created in the "Sessions" window. Lets talk skype if you need any help to reproduce this.

Reassigning back.

katuta commented 12 years ago

I will try to check is tomorrow at 13, when I come to innopoli. and then if I have a problem to reproduce it, i will call you. If it ok with you?

mataanin commented 12 years ago

Suits me.

Are you going to test today and tomorrow, or only tomorrow? I could show you today how to use the glucose measurements. Otherwise, I'll explain this in the email.

Maksim

On Thu, Dec 8, 2011 at 1:58 AM, Natalya Larsson < reply@reply.github.com

wrote:

I will try to check is tomorrow at 13, when I come to innopoli. and then if I have a problem to reproduce it, i will call you. If it ok with you?


Reply to this email directly or view it on GitHub: https://github.com/sizzlelab/side/issues/48#issuecomment-3060087

katuta commented 12 years ago

the portal I can test today from home. I cant come to Otaniemi today, but tomorrow I will be in Otaniemio, so I can test the mobile application. I do not know how to do with the glucose measurements, maybe Miyula can do it tomorrow?

miyula commented 12 years ago

I also don't know how to use the glucose measurements, and the port for inserting blood glucose test strip is sealed with transparent plastic with a message 'No Glucose'.

katuta commented 12 years ago

I am very sorry, but I couldn't come last Friday to innopoli. So I haven't tested it yet. I have very big difficulties with the time schedule. I can come to innopolli only next Thursday 15.12. Is it too late? if yes, can someone else to test it? I can work from home, but I have difficulties to go outside.

mataanin commented 12 years ago

No, thats not too late. Lets agree on time and I will also come to show you, how to measure glucose with Fora.

katuta commented 12 years ago

hi, we agreed with - Miyula, that I come to SoberIt on Thursday. I can be there at 11.15-12, but only for 1 hour, or after 18 in the evening

mataanin commented 12 years ago

Will be there.

katuta commented 12 years ago

at the moment, checked only with Samsung Galaxy, so far the new session is not created, without new measurements. but if to change the project code, then the new set of sessions is created for all previous measurement - but I am not sure if it is Ok or not.

mataanin commented 12 years ago

@katuta Sorry, I didn't understand what is the problem. Could we have a short skype call to figure it out sometime soon?

katuta commented 12 years ago

ok, I will explain tomorrow or on Wed, when we meet.

mataanin commented 12 years ago

It seems this is an obsolete issue.

katuta commented 12 years ago

Max! In the beginning of this issue, you and Miyula discussed that even if there is no Pulse data, we still record Accelerometer data and session should be created. But not situation is following: I do not have the belt paired at all, but if I go to Physical data section, accelerometer data is anyway recorded and session is created. Somehow, it doesn't feel right. So it creates a lot of irrelevant sessions.

I just report the finding, close this issue again, if you think that it is ok

mataanin commented 12 years ago

this should be ok. There will be cases when only accelerometer data will be needed.

katuta commented 12 years ago

ok, then no questions. It just feels a bit strange, that it creates so many not necessary sessions. It would be logical, if it created the session only when a user consciously pressed button Record. but, maybe it is ok, as now.