search

sj1999-BIT / pe

0 stars 0 forks source link

import json file unable to decribe the error #3

Open sj1999-BIT opened 3 years ago

sj1999-BIT commented 3 years ago

image.png

The warning here displayed that there is an error in the formatting. However what actually happened is that I did not change the format nor did I change the format of the file. I simply changed the name such that the name "Alex Yoeh" is repeated in different contacts.

image.png

This could potentially lead to huge inconvenience since you can add two contacts of the same name using you addCommand.

image.png

So the user maybe really confused as to where went wrong in his json file.

nus-pe-bot commented 3 years ago

Team's Response

The 3rd screenshot clearly shows 2 different names, 1 being "Alex Yeoh" the other being "Alex Yoeh" so this is already a non-concern, and since it was already mentioned in the user guide that 2 contacts are considered the same if they have the same name, the user should not be editing it so that 2 contacts have the exact same name in the first place and therefore its considered an invalid format.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: No, the "Alex Yeoh" contact was my own test case. In this case, the import data/test.json file clear had two contacts of the same name "Alex Yeoh". Not to mention that I have stated clearly in the image that I can't even import the file in the first place.

Secondly, since your app decided to allow users to import file, you need to make sure that the app can distinctly tell what is wrong with the file. For example, a professor, who belongs to your target users, could be importing a new file containing dozens of new students as tutors. What if two of the tutors has same name, like "Chua Wei Jie" for example?

Is it the professors job to go check through every single contacts to find out what was the error in the file syntax (which is the error message displayed here)? Not to mention that he or she will later realize that its not even an syntax error, but actually caused by duplicated names. And how is he supposed to deal with that?

User experience, especially you specific target users, are going to suffer!