nus-pe-bot
commented
3 years ago Team's Response
Same as the other issue, "Alex Yoeh" vs "Alex Yeoh".
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
import json file unable to decribe the error
The warning here displayed that there is an error in the formatting. However what actually happened is that I did not change the format nor did I change the format of the file. I simply changed the name such that the name "Alex Yoeh" is repeated in different contacts.
This could potentially lead to huge inconvenience since you can add two contacts of the same name using you addCommand.
So the user maybe really confused as to where went wrong in his json file.
[original: nus-cs2103-AY2122S1/pe-interim#2202] [original labels: type.FeatureFlaw severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
The 3rd screenshot clearly shows 2 different names, 1 being "Alex Yeoh" the other being "Alex Yoeh" so this is already a non-concern, and since it was already mentioned in the user guide that 2 contacts are considered the same if they have the same name, the user should not be editing it so that 2 contacts have the exact same name in the first place and therefore its considered an invalid format.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Again not the issue.
The problem is that your app does not sound off why is there a format error. How is having duplicated names a format error? Wouldn't it make more sense to just keep one and discard the duplicate? What if I am adding dozens of contacts in a new json file, which is most likely what a practical user will be doing? Am I suppose to manually search through all the contacts one by one to find out if it was the file corrupted or there is a repeated name?
As seen here, the import function worked on result.json even though "Alex Yeoh" is duplicated.
Which makes me very confused as to what went wrong in test.json, since all i did was switch the "Bernice Yu" contact name to "Alex Yeoh".
Moreover, It is also very confusing as to why the result states that duplicates are ignored, but then the duplicated "Alex Yoeh" contact is still present in the contact.