search

sj26 / mailcatcher

Catches mail and serves it through a dream.
http://mailcatcher.me
MIT License
6.31k stars 578 forks source link

remove dependency on haml for rails 3.2.3 #45

Closed linjunpop closed 12 years ago

linjunpop commented 12 years ago

according to https://github.com/rails/rails/issues/393 and https://github.com/haml/haml/blob/master/lib/haml/helpers/rails_323_textarea_fix.rb

I use slim with rails 3.2.3 in one of my company's projects, and in development env, I use mailcatcher. So it will cause issue even I didn't use HAML on my project.

One solution is update HAML to 3.1.6.rc.1 but I think that will cause conflict if someone need an older version of HAML.

So it seems that remove the dependency on HAML is a good solution. as there's only one view file views/index.haml.

sj26 commented 12 years ago

Please don't include mailcatcher in your Gemfile, it is a standalone application with it's own dependency set.

Mailcatcher should be installed as a separate gem (gem install mailcatcher) which is simply run as mailcatcher.

linjunpop commented 12 years ago

@sj26 Thanks for reply.

Maybe there should be an mountable engine for rails to make it more convenient to use.

And I think it would be better if you put don't include mailcatcher in the Gemfile in README file.

:smile:

sj26 commented 12 years ago

I don't really want to tie into Rails at all, there are projects like mail_view for that... but I will definitely add something to the README. Thanks!