sj26 / mailcatcher

Catches mail and serves it through a dream.
http://mailcatcher.me
MIT License
6.3k stars 575 forks source link

Reduce Docker image weight #478

Closed Jean-Beru closed 3 years ago

Jean-Beru commented 3 years ago

This repository now includes its own Docker image, so, there is no reason to keep my version (cf. https://hub.docker.com/repository/docker/jeanberu/mailcatcher). Since I built this image from alpine, it's a litte bit lighter (from 25Mo to 15Mo).

sj26 commented 3 years ago

This is some impressive layer golf!

Given how critical ruby is to the image, I'm not sure I want to be constrained to alpine's idea of the latest ruby version.

It's also kinda nice to be able to re-use the alpine ruby base layer for other images. I use this image quite a bit on my system, which becomes some space savings.

Is the extra few megabytes worth it?

Jean-Beru commented 3 years ago

I understand your point of view. Since ruby is critical, these 10Mo are not so important, you can close this PR if you want to.

sj26 commented 3 years ago

Thanks!