search

sj26 / mailcatcher

Catches mail and serves it through a dream.
http://mailcatcher.me
MIT License
6.3k stars 575 forks source link

gemspec - update eventmachine, rack, sinatra, sqlite3 #546

Closed MSP-Greg closed 4 months ago

MSP-Greg commented 1 year ago

I am not familiar with mailcatcher. In another repo, someone opened an issue about installing on Windows, and I took a look at the gemspec.

Some of the dependencies are locked to old versions, and with EventMachine, that's an issue.

So, I updated a few items, and ran CI. It passed in my fork, so I'll assume it passes here. EventMachine may have some issues with OpenSSL 3, not sure about thin.

Also, re Windows, the current EventMachine release includes a Windows pre-compiled gem, but its gemspec does not have a required_ruby_version properly set with an upper bound. It only includes extension files for Ruby 2.0 thru 2.3. It's also rather old...

sj26 commented 1 year ago

Ah yes, the old gems problem.

I locked down the versions of these gems because newer versions weren't running correctly. Especially skinny, the gem I wrote which used to power websockets. But I recently replaced skinny with a standard websocket gem, and then updated thin. There's a new version of mailcatcher, v0.9.0, out which I'm hoping will solve a bunch of issues by just updating thin. But eventmachine and friends are next on the block. (Ideally I'd like to remove and replace eventmachine, because it's a bit too old and fragile, probably with async.)

CI covers some things, but not all things. Mainly, do live updates via websockets still work?

MSP-Greg commented 1 year ago

I locked down the versions of these gems

Understandable. I was mostly concerned about EM, as that's really old. But even the current version is old. One might consider it 'no longer maintained'. I have contributed to it, but I don't actively use it.

CI covers some things, but not all things

Good to know.

do live updates via websockets still work?

Haven't checked. I'll see if I can check that.

sj26 commented 1 year ago

I tried a move conservative version, only upgrading eventmachine (1815bfe8adcf5858a9caba773f07dd5863908f65), and did some testing. Everything seems to be working. It is in a pre-release, v0.9.1.beta1 — please try it out:

gem install mailcatcher -v 0.9.1.beta1
sj26 commented 4 months ago

I think the rest of these updates are covered by #554.