sj26 / mailcatcher

Catches mail and serves it through a dream.
http://mailcatcher.me
MIT License
6.23k stars 571 forks source link

Update gem spec minimum versions #551

Closed benebrice closed 10 months ago

benebrice commented 10 months ago

Hi guys,

I'm currently upgrading my Gemfile and I have conflicts with rake minimum version which involve Sinatra for this case.

I've fork the latest version of Mailcatcher and update the mailcatcher.gemspec

I have change those:

s.add_dependency "rack", "~> 2.1"
s.add_dependency "sinatra", "~> 2"

Does anybody know if there are possible side effects. If there is none, I can open the PR. 🙂

sj26 commented 10 months ago

There are potential side effects.

Please don't include mailcatcher in your Gemfile:

https://github.com/sj26/mailcatcher#bundler

benebrice commented 10 months ago

Thanks @sj26 ! I've never read this note before. I'll extract if from my Gemfile. 👌🏻

sj26 commented 10 months ago

Thanks @benebrice :pray: