search

sj26 / rspec_junit_formatter

RSpec results that your CI can read
http://rubygems.org/gems/rspec_junit_formatter
MIT License
302 stars 122 forks source link

Show detail for failing examples using aggregate_failures #74

Open jasoncodes opened 5 years ago

jasoncodes commented 5 years ago

Fixes #56

Example

Before

After

Note

There is a minor change to how backtraces are formatted. It’s now the same as what rspec shows when ran from directly:

Before

After

xuantuan58 commented 5 years ago

I am waiting for review and merge from owner

sj26 commented 4 years ago

Sorry that this hasn't had attention in a while, @jasoncodes.

I really like this idea, but I'm very concerned that the parsing code seems to be a bit brittle and may break if future rspecs change output formats slightly. I'm not sure what the best answer here, which is why I haven't really jumped into it. 🤔

jasoncodes commented 4 years ago

What if I made the guards less strict so instead of raising on an unexpected format, they instead silently continue? This should at worst output a bit of duplication instead of erroring.

I’m not sure how to best add coverage for that though. Conditionally stub out fully_formatted_lines so it does something different than expected? Not sure if it’d be worth the effort.

taylorthurlow commented 4 years ago

@sj26 Sorry to bother, but do you have any further opinion on this?

taylorthurlow commented 3 years ago

@sj26 Any chance of an update?

dschweisguth commented 1 year ago

Right now we're running on a fork based on this PR. I too would appreciate any opinions on a way forward. Thanks!

dimitarizpitaime commented 1 year ago

Any updates on this guys, would really love to see it going in ?

krasnoukhov commented 1 year ago

This would be a great addition to merge and then cut a release...

Drowze commented 7 months ago

@sj26 any chance we can get this one on a new release? :)