Only adding future holidays and removing past holidays + Support for Regional holidays

sjackson0109 / TeamsScheduleNationalHolidays

MIT License

0 stars 1 forks source link

Only adding future holidays and removing past holidays + Support for Regional holidays #4

Closed mitchelljb closed 4 months ago

mitchelljb commented 4 months ago

Adjustment in script to only add Future holidays. Also with Updating, it will remove holidays from the past + will update the schedule as default (before it was creating a new schedule).

sjackson0109 commented 4 months ago

Another issue that you recognised and resolved without my help. Thank you!

Update needed:

Can the comment on line 10 -Not Append be updated to -NotAppend ? A simple space removal, to align the variable-name

Keep up the good work mate.

sjackson0109 commented 4 months ago

@mitchelljb - looks like you have a branch file conflict. Can I leave you to resolve once you update your PR ?

mitchelljb commented 4 months ago

@sjackson0109 - Fixed 😉 Even added support for Regional holidays

mitchelljb commented 4 months ago

@sjackson0109 Below fixes:

Fixed branch file conflict
updated script to allow "-NotAppend" switch when updating
Added regional holiday support with the switch "-Region". When not used, only Global (country accross) holidays will be added

sjackson0109 commented 4 months ago

Outstanding work @mitchelljb