Add Tests

[oussjarrousse]

Add tests to existing code and make sure test coverage is high. Use tox with pytest, pytest-flask etc.

• https://tox.readthedocs.io/en/latest/
• https://docs.pytest.org/en/stable/
• https://pytest-flask.readthedocs.io/en/latest/ .. .

[oussjarrousse]

I forked the project and started adding configuration files related to testing and also made small non-breaking changes to enferno, basically adding a TestConfig class to settings.py.

the folder structure provides a nice split between app code and test code as all test code is in one folder on the project root.

I will add some simple tests so that it provides a start towards covering much of the code with tests.

[oussjarrousse]

I am ready for a pull-request. You could check the changes I made on my fork here: https://github.com/oussjarrousse/bayanat/tree/testing

Could you please create a feature branch for this issue so that I create the pull request and we can discuss further.

[sjacgit]

Thank you very much for taking the time to contribute! We'll look into your changes and get back to you very soon.

[oussjarrousse]

I think open source projects like Bayanat requires automated tests because:

• without automated tests and high code coverage, an open source project cannot take advantage of public participation, because the workload to manually review all pull requests will be overwhelming.
• ensure a new feature does not break other parts of the code (unit tests, functional, integration tests, etc.)
• ensure there are no typos (ensure high test code coverage)
• ensure bugs that were previously fixed will not get re-introduced in future versions ( regression tests)
• ensure code security (security tests)
• having automated tests ensures better code quality from contributors and reduce the back and forth between contributors and maintainers. Because developers can test on their own before submitting the code for review.

Also as an enduser, I have much less trust in code without tests than with code that have high test coverage.

Please consider my offer to create a pull request that adds the testing boiler plate for the backend (with tox and pytest)... and I will be adding tests routinely until we get a good code coverage...

[sjacgit]

Hello again.

We really appreciate this offer.

We've been recently successful in acquiring funding to add tests to Bayanat. We were actually planning to reply to this issue next month :)

We expect to publish the first iteration of tests in January along with some guidelines. Please hang tight until then and we'd be happy to collaborate with you.

Meantime, if there are parts of the code for which you'd like to add tests, please let us know.

[sjacgit]

Thanks for your patience. We just pushed a new version that contains tests. We'll be adding more over the next few months. Please let us know if you have any suggestions/comments or if you'd like to contribute.