sjaehn / BOops

Sound glitch effect sequencer LV2 plugin
GNU General Public License v3.0
73 stars 2 forks source link

bpm and bpBar text not legible #26

Open hellocatfood opened 2 years ago

hellocatfood commented 2 years ago

I manually compiled 1.8.2 on Ubuntu 22.04 and I'm using the plugin in Ardour and Carla. When the playback mode is set to Autoplay the bpm and bpBar options become visible. However, when dragging the slider beyond a certain point the text on the slider becomes almost illegible.

Peek 2022-10-07 10-29a

The grey text on black background makes it really hard to read.

sjaehn commented 2 years ago

Right this is a known problem and I don't have a quick fix. The problem I created (yes, I feel guilty): as all sliders use the same font color. No matter what's the color of the slider. So it will be the same text color for red, green, yellow or white sliders. And it will be the same text color if the text is over the bar fill or over the dark background. Yes, there would be fancier ways to solve this.

Anyway, I tried to find the best compromise. But sometimes (like in the black/white sliders) it's really hard to read. I admit.

I'm just playing around with some fine tuning of colors and font weight. I'll come up soon with some quick results.

sjaehn commented 2 years ago

Quick fix: 49ce8dbef86e685b7b792f8b31c8e1aca458c3e4 Only minor improvement. I hope it's sufficient. More advanced methods to display the text over the slider bar may include shadowed text or outlined text or changing text colors depending on the background pixel. But all of them are a bit tricky to realize in combination with the editable value text. Unless I want to rewrite the old BWidgets::Label. And I don't want it.

hellocatfood commented 2 years ago

Thanks, this'll do for now but would definitely be better to find a permanent solution