search

sjagoe / cygit2

Cython wrapper around libgit2
Other
6 stars 2 forks source link

Question about pygit2 tests #6

Closed esc closed 11 years ago

esc commented 11 years ago

There was already previous attempts at cygit2:

https://github.com/libgit2/pygit2/issues/42

But that code seems no longer to be online :( Anyway I am very excited to see this kind of development! Anyway, at the time it was suggested to reuse the unit-test suite from pygit2 amongst other things. Recently, the pygit2 devs more or less decided that the pygit2 bindings should consist of a brain-dead wrappings and high-level pythonization:

https://github.com/libgit2/pygit2/issues/139

I think this should set the stage quite well for good synergies between pygit2 and cygit2, for example to re-use the test-suite.

sjagoe commented 11 years ago

Thanks for the comments. I actually had no idea that there was a previous attempt at Cython bindings. I admit I didn't really look too hard.

I have thought about API compatibility with their code, but it did not occur to me to reuse the pygit2 test suite. This is a great idea, and soon I'll start cleaning up my code to head in that direction. My development to this point has been largely a learning experience in a number of random directions through the libgit API.

sjagoe commented 11 years ago

I have started a pygit2 compatibility branch: import-pygit2-test-suite. Still a long way away with 112 errors of 119 tests. A lot of these are also functionality I don't have yet (e.g Repository.walk)

esc commented 11 years ago

:sparkles: :+1: it will perhaps be a good way to drive the implementation, as it were

sjagoe commented 11 years ago

In the interest of making things go as smoothly as possible, I have also just re-licensed under GPLv2 with the libgcc exception (i.e. same terms as pygit2) so that the projects can more easily share any code deemed necessary.

Also, pretend you didn't see the contents of the update-pygit2-tests.sh file :-)