search

sjamesr / jfreesane

Java API to talk to the SANE scanning daemon
Apache License 2.0
60 stars 25 forks source link

Remove final from SaneOption #86

Open phablotassio opened 5 years ago

phablotassio commented 5 years ago

Since final classes can't be mocked with regular mockito it's more useful to not be final.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 306

Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 923
Relevant Lines: 1139
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 306

Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 923
Relevant Lines: 1139
💛 - Coveralls
sjamesr commented 5 years ago

I don't have a problem with this change, but I'm not sure why you'd want to mock SaneOptions, unless you're also mocking interactions with the SANE server. It's best to interact with a real sane server if at all possible, even if it's one built with just the test backend.

Also, do you mind rebasing your change onto the latest HEAD? Thanks