sjamesr / jfreesane

Java API to talk to the SANE scanning daemon
Apache License 2.0
60 stars 25 forks source link

fix md5 authentication, remove guava deps #90

Open sjamesr opened 4 years ago

sjamesr commented 4 years ago

Previously, the code looking for $MD5$ preambles would always return false, as the '$' characters were quoted as if they were being passed to a regexp library. Splitter.on() did not take a regex, so this pattern never matched.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 405


Files with Coverage Reduction New Missed Lines %
src/main/java/au/com/southsky/jfreesane/SaneSession.java 1 83.22%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 403: 0.9%
Covered Lines: 1934
Relevant Lines: 2314

💛 - Coveralls
sjamesr commented 4 years ago

This change is probably OK, but authentication is broken on Ubuntu for unrelated reasons, see https://bugs.launchpad.net/ubuntu/+source/sane-backends/+bug/1858051