sjanssen2 / spike

NGS pipeline for SNV detection in tumor context
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

added a test for helper function _run2date #211

Closed sjanssen2 closed 5 years ago

sjanssen2 commented 5 years ago

I introduced a stupid bug in the function that parses dates from the "run" string, i.e. chose the wrong subscripts (see issue #210). That is very unfortunate as I don't know in how many samples this wrong date is now encoded :-/ On the other hand, this is a wonderful - because its small - example why you should always have unit-tests in place, which I had not.

With this PR, you see the ideal procedure: 1) create a new test that replicates the reported wrong behaviour and leads to a failing test (29ec512) 2) fix the bug and show that tests now pass (1128d31).