sjarvela / kloudspeaker

Document management system
GNU General Public License v2.0
95 stars 40 forks source link

Error with filters at Notifications plugin #132

Open geovls opened 8 years ago

geovls commented 8 years ago

When i use a filter(parent folder or any parent folder) to an event, the email notification will NOT be sent if the users that trigger the notification are not added to the top most folder of my folder's stucture.

sjarvela commented 8 years ago

Could you take a screenshot and/or descrption of the filter/scenario, so I could replicate the case?

What I don't quite understand is

...if the users that trigger the notification are not added to the top most folder of my folder's stucture

geovls commented 8 years ago

Good morningand thank you for your response…This is apart of the folder’s structure that I use. Each subfolder in MHXANIKOI correspondsto a specific user. Thescenario that doesn’t work is this:Let’s saythat a user named USER1 will upload a file to the subfolder VLACHOS_GIORGOS andan email will be sent to the owner of that subfolder, USER2. At thenotifications panel I choose the followings:Events thattrigger notification: filesystem/uploadEventfilter: Any parent folder, Value: The subfolder VLACHOS_GIORGOSUsers thattrigger the notification: USER1Users whoreceive notification: USER2 The emailwill be sent only if the USER1 is a user of the top folder: COMMUNICATIONIf he isn’ta user of the folder COMMUNICATION the filter doesn’t work and no email is sent.

Στις 4:02 μ.μ. Πέμπτη, 26 Μαΐου 2016, ο/η sjarvela <notifications@github.com> έγραψε:

Could you take a screenshot and/or descrption of the filter/scenario, so I could replicate the case?What I don't quite understand is ...if the users that trigger the notification are not added to the top most folder of my folder's stucture — You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

sjarvela commented 8 years ago

So if I understood correctly, you have following folder structure:

In this case you should not have "Parent folder" published in Kloudspeaker at all. Ie. you should publish only real folders "Sub folder 1", "Sub folder 2" etc, and assign these to correct users. If some user needs to see more than one, assign them all.

The rule is that there should not be two published folders that leads to same physical folder, because they are each separate instances and don't share any metadata like permissions, descriptions etc.

This is also probably the reason why filter does not work: when you select the parent folder, you choose it from one of the instances (for example "Parent folder"). If the actual user is assigned to the other instance (for example "Sub folder 1"), the parent filter does not match, because it is not from the same instance.

geovls commented 8 years ago

I don't quite understand your answer. My problem has to do with the filters at notification.Let's say that i have the following structure. 

If i set a notification in which user1 uploads a file to Sub folder 2 and sends an email to user 2, the email won't be sent unless Parent folder or Sub folder 2 is assigned to user 1.  If, for example, Sub folder 1 is assigned to user 1 the above notification won't work. 

Στις 11:05 π.μ. Τετάρτη, 1 Ιουνίου 2016, ο/η sjarvela <notifications@github.com> έγραψε:

So if I understood correctly, you have following folder structure:

In this case you should not have "Parent folder" published in Kloudspeaker at all. Ie. you should publish only real folders "Sub folder 1", "Sub folder 2" etc, and assign these to correct users. If some user needs to see more than one, assign them all.But the rule is that there should must not be two published folders that leads to same physical folder, because they are each separate instances and don't share any metadata like permissions, descriptions etc.— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

sjarvela commented 8 years ago

That's what I'm trying to say, you should not have "Parent folder" assigned to anyone, it shouldn't even be added to the Folders list in admin. So if you go to admin->Folders, you should have only "Sub folder 1", "Sub folder 2" etc, no parent folder (and none of the folders listed should point to same location). And then assign these subfolders for users.

I tried similar configuration with notification filter, and could not see any problems.