search

sjbarag / brs

An interpreter for the BrightScript language that runs on non-Roku platforms.
MIT License
113 stars 43 forks source link

feat(stdlib,exts): implement Tr #578

Closed lkipke closed 3 years ago

lkipke commented 3 years ago

Summary

This implements the stdlib Tr function (link to docs). Closes #496

lkipke commented 3 years ago

Looks great! We may be missing a few bits of the TS file spec (and we don't seem to support XLIFF files yet) but we can handle those in a separate PR as needed.

Yep, that was my thought as well 👍

nadiapadalka commented 3 years ago

Hi @lkipke , I've tried to call Tr without mocking but I'm receiving the translations source like: "HELLO_WORLD" but not the translated text "Hello, world!", error is not present anymore, but looks like Tr not working properly(

sjbarag commented 3 years ago

Hey @nadiapadalka — please don't post references to confidential materials here, including translations. I'm redacting parts of your comment.

sjbarag commented 3 years ago

Hi @lkipke , I've tried to call Tr without mocking but I'm receiving the translations source like: "HELLO_WORLD" but not the translated text "Hello, world!", error is not present anymore, but looks like Tr not working properly(

@nadiapadalka That may be solved by #587 , which was released in v0.39.0. Please try again with that version of the interpreter. If you still see that error, please file a new issue with the simplest file(s) you can find that reproduce the issue 😃

nadiapadalka commented 3 years ago

Hey @nadiapadalka — please don't post references to confidential materials here, including translations. I'm redacting parts of your comment.

@sjbarag , sure, sorry

nadiapadalka commented 3 years ago

Hi @lkipke , I've tried to call Tr without mocking but I'm receiving the translations source like: "HELLO_WORLD" but not the translated text "Hello, world!", error is not present anymore, but looks like Tr not working properly(

@nadiapadalka That may be solved by #587 , which was released in v0.39.0. Please try again with that version of the interpreter. If you still see that error, please file a new issue with the simplest file(s) you can find that reproduce the issue 😃

thanks @sjbarag ok, I will try