search

sjbarag / brs

An interpreter for the BrightScript language that runs on non-Roku platforms.
MIT License
114 stars 43 forks source link

fix(interp): Coerce function arguments and variable assignments into desired types #620

Closed vbuchii closed 3 years ago

vbuchii commented 3 years ago

609

While running on interpreter:

Screenshot 2021-01-27 at 19 08 40

On Roku:

Screenshot 2021-01-27 at 19 11 57

vbuchii commented 3 years ago

Hi, @sjbarag I've added typecasting but we have different behavior as on Roku. I'm not very familiar with JS and would like to get your feedback on what we should do with that. I skipped a part of the tests and left comments above them. Also, you can find screenshots attached to the PR's description. Thanks

sjbarag commented 3 years ago

Thanks for getting this started, @vbuchii! The implementation looks pretty close, so I'm going to pick it up from here 😃 I'll push some commits to this PR, so don't panic if you see some notifications in your email.