search

sjbarag / brs

An interpreter for the BrightScript language that runs on non-Roku platforms.
MIT License
113 stars 43 forks source link

feat(rsg): Add boundingrect function to node #665

Closed underwoo16 closed 2 years ago

underwoo16 commented 2 years ago

Implemented boundingRect function for roSGNode with zero-defaulted values

https://developer.roku.com/docs/references/brightscript/interfaces/ifsgnodeboundingrect.md

underwoo16 commented 2 years ago

I'm fine with this, given that we have several other components with skeleton implementations. Can you also open a PR into roca to update the docs? Probably this one specifically: implementation-gaps.md

I think the comment that it is mostly complete is still accurate since I only implemented one out of ~7 methods from this interface. I have never seen the other methods used so I only implemented boundingrect.

Would you prefer I implement all of the methods or file an issue to complete the missing methods?

sjbarag commented 2 years ago

I'm fine with this, given that we have several other components with skeleton implementations. Can you also open a PR into roca to update the docs? Probably this one specifically: implementation-gaps.md

I think the comment that it is mostly complete is still accurate since I only implemented one out of ~7 methods from this interface. I have never seen the other methods used so I only implemented boundingrect.

Would you prefer I implement all of the methods or file an issue to complete the missing methods?

You're fine as-is for now 🤷 It's still mostly-complete, and we're getting closer slowly