search

sjc5 / hwy

Hwy is a fullstack web framework for driving a (p)react frontend with a Go backend. Includes end-to-end typesafety, file-based nested UI routing, and much more.
BSD 3-Clause "New" or "Revised" License
320 stars 3 forks source link

docs: rewrote and reorganised landing page of hwy.dev. #49

Closed jaymanmdev closed 11 months ago

jaymanmdev commented 11 months ago

I have worked on a rewrite/reorganization of the documentation landing page. If there are any issues with the rewrite or I missed something important @sjc5, then please let me know and I'll make revisions. :)

I also removed the /jeff page route as I couldn't see any use for it in the documentation. Maybe it was left over from when you were doing some framework testing?

Preview deployment can be found at https://hwy-docs-git-fork-jaymanmdev-main-hwy.vercel.app

Thanks!

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hwy-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 4:01am
sjc5 commented 11 months ago

Thanks Jayman. We're going to keep it as is for now. This is the sort of thing that is better to raise in an issue first before opening a PR (this is going to be true in all libraries, not just Hwy). It just makes sure everyone is on the same page before spending time working on something. Really appreciate the enthusiasm and input.

jaymanmdev commented 11 months ago

Thanks Jayman. We're going to keep it as is for now. This is the sort of thing that is better to raise in an issue first before opening a PR (this is going to be true in all libraries, not just Hwy). It just makes sure everyone is on the same page before spending time working on something. Really appreciate the enthusiasm and input.

I see, no worries, my bad @sjc5. 🙏 I should have opened an issue to discuss these things first - I understand, and if you change your mind at some point then the PR is here. I just wanted to start contributing as I am very invested in Hwy and I want to be a big part of its future, that's all. I apologise. :)

If you have any places that I could contribute to now, then I'd love to spend some time on those, so let me know. :)

sjc5 commented 11 months ago

No need to apologize @jaymanmdev! All is good :)

Any more thoughts on the Kita types? I just noticed this: https://github.com/orgs/honojs/discussions/1767

jaymanmdev commented 11 months ago

No need to apologize @jaymanmdev! All is good :)

Any more thoughts on the Kita types? I just noticed this: https://github.com/orgs/honojs/discussions/1767

I do have it working in my project. It's a very simple change I believe. I'll make an issue for this, 1 sec.