search

sjc5 / hwy

Hwy is a fullstack web framework for driving a (p)react frontend with a Go backend. Includes end-to-end typesafety, file-based nested UI routing, and much more.
BSD 3-Clause "New" or "Revised" License
319 stars 3 forks source link

feat: add `htmx.d.ts` file into `packages/core/types`. #52

Closed jaymanmdev closed 11 months ago

jaymanmdev commented 11 months ago

This PR proposes a type declaration file for HTMX types, with proper copyright notices and licenses for htmx, typed-htmx and kitajs/html.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hwy-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:51am
sjc5 commented 11 months ago

Closes #51

jaymanmdev commented 11 months ago

@sjc5 how is this coming along? is a 0.7.2 beta release for this still planned for today? 0.8.0-beta.7 has the updated package.json but doesn't include the types directory. :)

sjc5 commented 11 months ago

Hang tight on this one. I'm having a re-think about whether we want to be maintaining third-party type references like this in this repo (something about it conceptually isn't sitting right), as well as reconsidering the core JSX rendering lib (considering moving to Preact over Hono JSX, as it's much more stable and mature). In which case this wouldn't be relevant. Thanks. In the meantime feel free to publish this file in a side library if you'd like.

jaymanmdev commented 11 months ago

Hang tight on this one. I'm having a re-think about whether we want to be maintaining third-party type references like this in this repo (something about it conceptually isn't sitting right), as well as reconsidering the core JSX rendering lib (considering moving to Preact over Hono JSX, as it's much more stable and mature). In which case this wouldn't be relevant. Thanks. In the meantime feel free to publish this file in a side library if you'd like.

Oh, I see. That's fair enough. I am personally against moving to Preact. Preact doesn't really have a great Streaming/Suspense story and I think that Hono's streaming capabilities are incredible, albeit experimental. Your choice though. :)