sjdemartini / mui-tiptap

A Material UI (MUI) styled WYSIWYG rich text editor, using Tiptap
MIT License
319 stars 43 forks source link

Unindent button icon is wrong #168

Closed mydoooom closed 1 year ago

mydoooom commented 1 year ago
Screenshot 2023-10-08 at 15 21 54

Here on the repo on src/controls/MenuButtonUnindent.tsx, the button import is correct, but when I checked my project's node_modules in node_modules/mui-tiptap/dist/controls/MenuButtonUnindent.js, there's const FormatIndentIncrease_1 = __importDefault(require("@mui/icons-material/FormatIndentIncrease")); on line 7

sjdemartini commented 1 year ago

Thanks for reporting! It looks like the name for the default import is correct, but it's not referencing the right path anymore https://github.com/sjdemartini/mui-tiptap/blob/82271b8e2a66cba742762fda1cdb80f7414130c2/src/controls/MenuButtonUnindent.tsx#L1 as of a change in v1.8.3. I won't be able to get to a computer for a little bit, but I'll fix and release once I'm able! In the meantime you can downgrade to 1.8.2.

sjdemartini commented 1 year ago

This is fixed in the newly published 1.8.4. Thanks again for reporting!

mydoooom commented 1 year ago

Awesome, thank you!

On 13. 10. 2023, at 7:05, Steven DeMartini @.***> wrote:

This is fixed in the newly published 1.8.4 https://github.com/sjdemartini/mui-tiptap/releases/tag/v1.8.4. Thanks again for reporting!

— Reply to this email directly, view it on GitHub https://github.com/sjdemartini/mui-tiptap/issues/168#issuecomment-1760829014, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUYEQPUELQG25GM3RYVSYTX7DD2RANCNFSM6AAAAAA5XWN6L4. You are receiving this because you authored the thread.