would it be possible to add a aria-label to the inputs like font family and font size? There currently is one, but it's not on the input so there is a missing label error from an accessibility standpoint
For what it's worth, the Select's input itself has aria-hidden="true", so I don't think it needs the aria-label, but there may be a better way to handle a11y with these components.
Please leave a comment and/or feel free to make a PR if you have suggestions on the "right way" to improve this!
Originally posted by @sgober in https://github.com/sjdemartini/mui-tiptap/issues/174#issuecomment-1785888733
Based on https://mui.com/material-ui/react-select/#accessibility, it seems we perhaps shouldn't be providing an
aria-labelthe way we are, though it's not entirely clear to me what the right pattern is when you don't have a separate label element. (https://mui.com/material-ui/react-select/#accessibility, https://mui.com/material-ui/react-text-field/#accessibility)For what it's worth, the
Select'sinputitself hasaria-hidden="true", so I don't think it needs the aria-label, but there may be a better way to handle a11y with these components.Please leave a comment and/or feel free to make a PR if you have suggestions on the "right way" to improve this!