search

sjdemartini / mui-tiptap

A Material UI (MUI) styled WYSIWYG rich text editor, using Tiptap
MIT License
320 stars 44 forks source link

Mui v6 support #266

Closed Xhale1 closed 2 months ago

Xhale1 commented 3 months ago

Mui v6 released a few days ago, it'd be amazing to see this library support it someday!

I don't intend to rush anything, just wanted to log an issue to start some awareness. Love the library :)

sjdemartini commented 3 months ago

Agreed! This is on my radar. Also happy to accept a PR for this. 😄 From reading the release notes, I'm hoping it won't be too difficult to support both v5 and v6, but we'll see.

Xhale1 commented 2 months ago

Looks like this library might already support v6! I cloned the repo and updated the dependencies and the dev server, tests, linting, and type checking all look good!

I can start a PR, though I'm not sure what the best path forward would be for running tests on both mui v5 and mui v6. I can experiment with something similar to what I'm using in @hello-pangea/dnd though I'm not sold on that being the best implementation.

Xhale1 commented 2 months ago

I opened PR #267 :)

Xhale1 commented 2 months ago

Gonna close this as #267 got merged and released in v1.11.0