When "type": "commonjs" is specified in our package.json, it apparently causes the following problem in NextJS:
Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (1:0)
> export { default as ControlledBubbleMenu, } from "./ControlledBubbleMenu";
| export { default as LinkBubbleMenu, } from "./LinkBubbleMenu";
| export { default as MenuBar } from "./MenuBar";
This is odd, since we indeed are using "commonjs" type, as that's the default (https://nodejs.org/api/packages.html#type), but it seems that fortunately merely omitting this resolves import errors in NextJS, and still supports NodeJS, based on my testing.
Note that I did try other approaches in attempting to fix NextJS and still support Node:
Using tsup/rollup again like #258, with @mui/icons-material bumped to v6 for supposed "proper" ESM support https://github.com/sjdemartini/mui-tiptap/issues/264#issuecomment-2346621784, but that still caused problems in the Node context. It seems icons-material still doesn't use .js extensions, so is still not correct.
Switch to "type": "module", using .js extensions for all relative imports in the project (enforced/automated with the eslint plugin eslint-plugin-require-extensions). This seemed like an improvement, but still seems it would require some workarounds for lodash and/or mui/icons-material like in #258 in the Node context, as those imports of the third party dependencies failed when importing mui-tiptap.
When
"type": "commonjs"is specified in our package.json, it apparently causes the following problem in NextJS:This is odd, since we indeed are using "commonjs" type, as that's the default (https://nodejs.org/api/packages.html#type), but it seems that fortunately merely omitting this resolves import errors in NextJS, and still supports NodeJS, based on my testing.
Should resolve https://github.com/sjdemartini/mui-tiptap/issues/264, removing one of the changes from https://github.com/sjdemartini/mui-tiptap/pull/259, while still hopefully keeping https://github.com/sjdemartini/mui-tiptap/issues/256 fixed.
Note that I did try other approaches in attempting to fix NextJS and still support Node:
@mui/icons-materialbumped to v6 for supposed "proper" ESM support https://github.com/sjdemartini/mui-tiptap/issues/264#issuecomment-2346621784, but that still caused problems in the Node context. It seems icons-material still doesn't use.jsextensions, so is still not correct."type": "module", using.jsextensions for all relative imports in the project (enforced/automated with the eslint plugineslint-plugin-require-extensions). This seemed like an improvement, but still seems it would require some workarounds for lodash and/or mui/icons-material like in #258 in the Node context, as those imports of the third party dependencies failed when importing mui-tiptap.