search

sjdemartini / mui-tiptap

A Material UI (MUI) styled WYSIWYG rich text editor, using Tiptap
MIT License
319 stars 43 forks source link

React v19 breaks 'ref' & keyboard support #300

Closed CHE1RON closed 4 days ago

CHE1RON commented 4 days ago

When using React v19 (currently in RC status), the ref cannot be passed correctly (since React v19 passes refs as props I assume), therefore calling functions (like upHandler etc) stops working.

sjdemartini commented 4 days ago

@CHE1RON I haven't tested mui-tiptap with React 19, thanks for the heads up. You specifically reference upHandler which is actually not part of the published mui-tiptap package, but is just used in the internal "demo". Do you know what (if anything) breaks for mui-tiptap itself? Would you be able to provide any additional details if so? Thanks.

CHE1RON commented 4 days ago

Hey there @sjdemartini! I've been looking into this, and the issue appears when removing this forwardRef and turning the ref into a prop (which should be redundant with React v19).

But you're right, it's not directly related to your awesome library 😎 Thanks for answering on such short notice!

Cheers CHE1RON