search

sjeknic / CellTK

Toolkit for analysis of live-cell microscopy data
MIT License
3 stars 0 forks source link

`Operation` input and output requests need to be more specific #74

Closed sjeknic closed 2 years ago

sjeknic commented 2 years ago

I basically broke the original idea for Pipeline._input_output_handler. Right now, Pipeline basically just loads all of the images that it can find, which is good if you want to find outputs to not run them again. However, if force_rerun=True then those extra output images might get passed instead of the expected images. This would have previously likely raised an Error based on passing too many args.

Regardless, Operation.get_inputs_outputs should take into account whether force_rerun is True. And also, the distinction between inputs and outputs in this context is a little bit minor. So they should be consolidated to a single argument.

sjeknic commented 2 years ago

See #75. A simple work around was introduced such that Operation accounts for the value of force_rerun. However, a better fix, that actually consolidates inputs and outputs, would still be beneficial.

But for the sake of cleaning things up, I'm going to close this issue for now and come back to it if another bug crops up.