search

sjelfull / Craft-CacheWarmer

Warm up your cache with a single request.
38 stars 4 forks source link

Set default locale to en_us #1

Closed gmhenderson closed 8 years ago

gmhenderson commented 8 years ago

Perhaps this changed at some point, but my default English locale in Craft is U.S. English: en_us.

gmhenderson commented 8 years ago

On second though, this PR probably doesn't make much sense. It just took me a little while to figure out why none of my entries were getting warmed: I had the wrong locale.

sjelfull commented 8 years ago

Your probably right - I guess this plugin should have multiple locale support either way.

The second change, does it cause an exception if any of the requests in the batch returns 404? Not sure if that is something you want. Maybe better if it logs it?

gmhenderson commented 8 years ago

Oops, I forgot that subsequent commits would be included in the PR. I was just experimenting. But yes, I do need the plugin to keep running even if it encounters errors. I also needed it to not verify the SSL cert if in the local environment.

I'm not sure how useful the SSL thing would be for others, but buffering exceptions probably would be.