search

sjelfull / craft3-imgix

Use Imgix with Craft
https://superbig.co
MIT License
13 stars 7 forks source link

Volume subfolders not reflected in URL #10

Closed jawngee closed 2 years ago

jawngee commented 6 years ago

If I've defined a subfolder for the asset volume, the generated imgix URLs don't include the subpath which leads to broken 404 error'd images.

Am I doing something wrong?

(Sorry, initially commented on the wrong repo).

skramstad commented 6 years ago

Did you solve it?

If you have a subfolder, just add it in your imgix path. 'imgixDomains' => [ 'images' => 'somename.imgix.net/subfoldername', ],

sjelfull commented 6 years ago

@jawngee does ☝️ fix it?

leevigraham commented 3 years ago

FYI @skramstad fix breaks purging.

This is becuase the src/services/ImgixService.php and src/models/ImgixModel.php generate the URLs differently

leevigraham commented 3 years ago

Rather than change the way the ImgixModel works to fix the purging issue I've changed the way the purging url generation logic works to use the same logic as the ImgixModel

https://github.com/sjelfull/craft3-imgix/pull/28

sjelfull commented 2 years ago

The fix from #28 is out now in 3.0.0