sjgregory97 / cruelty-free-site

Cruelty Free Website
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

Single-Serving Wiki To-Dos

20 to-dos, 5 points each; plus 4 extra credit to-dos

Essential

Code

30 points

Design

45 points

Optimization

5 points

Test

10 points

Git

10 points

Extra Extra

20 points

jgagne commented 7 years ago

Rename index.web.html to index.html.

jgagne commented 7 years ago

Resolve HTML issues: https://validator.w3.org/nu/?doc=https%3A%2F%2Fsjgregory97.github.io%2Fcruelty-free-site%2Findex.web.html

Minor Issues

Before

<section>
  <nav>
    <ul class="menu">
      <li> <a href="#hist"> <b>History</b> </a> </li>
      <li> <a href="#camp"> <b>Campaigns</b> </a></li>
      <li> <a href="#test"> <b>Tests </b></a> </li>
      <li> <a href="#alt"> <b>Alternatives</b> </a> </li>
      <li><a href="#prod"> <b>Products </b> </a> </li>
      <li> <a href="#even"> <b>Events</b> </a> </li>
      <li> <a href="#crit"> <b>Criticisms</b> </a> </li>
    </ul>
    <hr>
    <ul>
      <li> <a href="#also"> See Also </a></li>
      <li> <a href="#ref"> References </a> </li>
    </ul>
</section>
</nav>

Note: Improper nesting of tags. However, the easier way thing to do is just remove the <section> element, since the <nav> element is already a sectioning element.

After

<nav>
  <ul class="menu">
    <li> <a href="#hist"> <b>History</b> </a> </li>
    <li> <a href="#camp"> <b>Campaigns</b> </a></li>
    <li> <a href="#test"> <b>Tests </b></a> </li>
    <li> <a href="#alt"> <b>Alternatives</b> </a> </li>
    <li><a href="#prod"> <b>Products </b> </a> </li>
    <li> <a href="#even"> <b>Events</b> </a> </li>
    <li> <a href="#crit"> <b>Criticisms</b> </a> </li>
  </ul>
  <hr>
  <ul>
    <li> <a href="#also"> See Also </a></li>
    <li> <a href="#ref"> References </a> </li>
  </ul>
</nav>

Before

<p >
The term cruelty-free was first used in this way by Lady Dowding who persuaded manufacturers of fake furs to use the label Beauty Without Cruelty and went on to found the charity Beauty Without Cruelty in 1959.<a href="#three">[3] </a>The term was popularised in the USA in the 1970s by Marcia Pearson who founded the group Fashion With Compassion
</p> </h2>

Note: You have a few stray tags. For example, remove </h2>. Be sure to validate for details.

After

<p>
The term cruelty-free was first used in this way by Lady Dowding who persuaded manufacturers of fake furs to use the label Beauty Without Cruelty and went on to found the charity Beauty Without Cruelty in 1959.<a href="#three">[3] </a>The term was popularised in the USA in the 1970s by Marcia Pearson who founded the group Fashion With Compassion
</p>

Before

<h4>
  <nav>
<div class=back_to_top>
  <a href ="#top"> <strong> Back to top ↑</strong> </a>  </div></nav>
</h4>

Notes

After

<div class="back_to_top">
  <a href="#top"><strong>Back to top ↑</strong></a>
</div>
jgagne commented 7 years ago

Resolve CSS issues: http://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fsjgregory97.github.io%2Fcruelty-free-site%2Findex.web.html%23two&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

Minor Issues

jgagne commented 7 years ago

Add a meta description and include <link rel="canonical" href="…"> (add url) to cite the original source of content.

jgagne commented 7 years ago

Add a description and url to your GitHub repo:

cexewbq

jgagne commented 7 years ago

Add comps folder with included comp for reference.

jgagne commented 7 years ago

Style links, <a> tags, other than the default color (blue).