search

sjhoeksma / cordova-plugin-keychain-touch-id

Touch ID plugin with saving password in keychain for IOS and android
87 stars 160 forks source link

Add prefix to string values ok and cancel to avoid conflict with other plugins #32

Open vramanalj opened 6 years ago

vramanalj commented 6 years ago

fpauth-strings.xml in res/values and res/values-es have 2 strings declared

<string name="ok">Ok</string>
<string name="cancel">Cancel</string>

These are fairly common string names used in other plugins and causes build issue when making an android build with the error: I'm getting this issue when using this plugin with IBM MFP plugin.

Execution failed for task ':mergeDebugResources'.
> [string/cancel] /Users/***/platforms/android/res/values/fpauth-strings.xml    [string/cancel] /Users/***/platforms/android/res/values/mfp-strings.xml: Error: Duplicate resources

[string-es/cancel] /Users/***/platforms/android/res/values-es/fpauth-strings.xml    [string-es/cancel] /Users/***/platforms/android/res/values-es/mfp-strings.xml: Error: Duplicate resources
wilk-polarny commented 6 years ago

Yea, that's also an issue for us. We worked around it by patching the platform using hooks.