search

sjiveson / nfs-server-alpine

A handy Alpine Linux based NFS Server image running NFS v4 only, over TCP on port 2049
https://hub.docker.com/r/itsthenetwork/nfs-server-alpine/
GNU General Public License v3.0
295 stars 187 forks source link

Changed source of the confd binary. #16

Closed bronger closed 6 years ago

bronger commented 6 years ago

I think it makes this image much more trustworthy if it does not include a binary blob. Besides, it is suboptimal to have a binary in a Git repo in the first place. Thus, I suggest to build confd in a two-step Dockerfile.

sjiveson commented 6 years ago

Hey,

Thank you, I like this a lot. I'll give it a run through tonight~this weekend and if that goes well I'll merge it.

sjiveson commented 6 years ago

OK, it built just fine which is great. However, it increased the image size by approx. 20MB, any idea why? Also, is there a reason your are pinning confd to v0.14?

bronger commented 6 years ago

No idea. I would have thought just the binary is copied into the image, as it has been before. Just that the source is different. Very odd.

I pinned for no particular reason. Sometimes, new versions cause incompatibilities. It depends on how confd is being developed. I don't have experience with this program.

bronger commented 6 years ago

https://github.com/kelseyhightower/confd/blob/master/docs/installation.md#build-for-your-image-using-multi-stage-build uses go install instead of make. Possibly one could give this a try.

sjiveson commented 6 years ago

I gave it a go, it didn't help. I'll experiment further later today. In any case, its still a relatively small image so I think its still worth doing.

sjiveson commented 6 years ago

I think its mostly just the confd binary being much bigger with v0.16. I'll move back to 0.14 and then get this merged

sjiveson commented 6 years ago

OK, I've done it the other way using the kelsey example you linked to and dropping to v0.14. Its still bigger but worth the overhead I think. I'll close this off. Have mentioned in the readme it was your idea - thanks again.