search

sjkp / letsencrypt-siteextension

Azure Web App Site Extension for easy installation and configuration of Let's Encrypt issued SSL certifcates for custom domain names.
744 stars 76 forks source link

Update Microsoft.Azure.Management.WebSites or constrain dependency version #371

Open ohadschn opened 4 years ago

ohadschn commented 4 years ago

letsencrypt.azure.core lists Microsoft.Azure.Management.WebSites as a dependency with the condition: >= 2.0.1

However upgrading Microsoft.Azure.Management.WebSites to version 3.0.0 results in: 

Error during Request or install certificate System.MissingMethodException: Method not found: 'Void Microsoft.Azure.Management.WebSites.Models.Certificate..ctor(System.String, System.String, System.String, System.String, System.String, System.String, System.Collections.Generic.IDictionary`2<System.String,System.String>, System.String, System.String, System.Collections.Generic.IList`1<System.String>, Byte[], System.String, System.String, System.String, System.Nullable`1<System.DateTime>, System.Nullable`1<System.DateTime>, System.String, System.Nullable`1<Boolean>, Byte[], System.String, Microsoft.Azure.Management.WebSites.Models.HostingEnvironmentProfile, System.String, System.String, System.Nullable`1<Microsoft.Azure.Management.WebSites.Models.KeyVaultSecretStatus>, System.String)'.
   at LetsEncrypt.Azure.Core.Services.WebAppCertificateService.<Install>d__3.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at LetsEncrypt.Azure.Core.Services.WebAppCertificateService.Install(ICertificateInstallModel model)
   at LetsEncrypt.Azure.Core.CertificateManager.<RequestAndInstallInternalAsync>d__15.MoveNext()

Looking at the ctor, looks like 3.0.0 indeed broke backwards compatibility (added an additional canonicalName param to the ctor). So letsencrypt.azure.core should be either upgraded, or specified with the correct dependency, namely >= 2.0.1 && < 3.0.0