search

sjmgarnier / viridis

Colorblind-Friendly Color Maps for R
http://sjmgarnier.github.io/viridis
Other
289 stars 38 forks source link

Don't import ggplot2? #40

Closed hadley closed 7 years ago

hadley commented 7 years ago

Because then I could use it from ggplot2 to replace the current continuous colour scheme

https://github.com/tidyverse/ggplot2/issues/1823

sjmgarnier commented 7 years ago

@hadley Would viridisLite be what you're looking for?

hadley commented 7 years ago

Yes, although it concerns me that viridis does not appear to import viridisLite.

sjmgarnier commented 7 years ago

@hadley I guess this is an historical oversight. We wrote and released viridis first, with the ggplot2 scales included (hence the ggplot2 dependency). Then someone asked us to make a more basic version because they didn't want their packages to depend on ggplot2. So we just stripped down viridis to make viridisLite. I guess we could have been smarter and do as you suggest. I will try to fix this when I find the time.

sjmgarnier commented 7 years ago

We have made viridis dependent on viridisLite in 1158a5e. This should resolve the problem.