search

sjmog / ralyxa

A Ruby framework for interacting with Amazon Alexa.
MIT License
180 stars 24 forks source link

Check Signature of Request #1

Closed sjmog closed 6 years ago

sjmog commented 7 years ago

Users of this gem should be able to configure signature-checking through it as painlessly as possible.

There is an NPM Package which does this for node-based Alexa skills.

mattrayner commented 6 years ago

I'll pick this up now :+1: already got a partial implementation

sjmog commented 6 years ago

Awesome @mattrayner , thanks so much!

mattrayner commented 6 years ago

Hi @sjmog, Off the back of this I've been working on a GEM which can be found here: https://github.com/mattrayner/alexa_request_verifier

There was already a gem with partial functionality available here: https://github.com/sidoh/alexa_verifier

I've been in contact with @sidoh about merging our efforts back into his alexa_verifier gem.

In the meantime I have a PR open on my own gem at: https://github.com/mattrayner/alexa_request_verifier/pulls/1 that adds configuration options into the mix.

If you're happy with the above I'll begin some integration work? Did you have any thoughts here or are you happy for me to just 'have at it'?

mattrayner commented 6 years ago

Following on from the above message, alexa_request_verifier has now been merged into alexa_verifier and I will begin work on integrating it into ralyxa shortly

sjmog commented 6 years ago

Awesome – thank you @mattrayner

Both your verifier and @sidoh's verifier look super-reasonable to me.

Would you be happy to do a doc update to Ralyxa's README, too?

mattrayner commented 6 years ago

Definitely - I’m in the process of integrating it directly into Ralyxa with a config block to toggle the verification - once I’ve done that I’ll create a PR On Mon, 4 Dec 2017 at 10:29 Sam Morgan notifications@github.com wrote:

Awesome – thank you @mattrayner https://github.com/mattrayner

Both your verifier https://github.com/mattrayner/alexa_request_verifier and @sidoh https://github.com/sidoh's verifier https://github.com/sidoh/alexa_verifier look super-reasonable to me.

Would you be happy to do a doc update to Ralyxa's README, too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sjmog/ralyxa/issues/1#issuecomment-348921794, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVzNuW29HMTkYb4zbuXHl_oBOP8Pkn8ks5s88mYgaJpZM4OG48P .

sjmog commented 6 years ago

Closed by #3