sjnyag / stamp

Most personal music player
Apache License 2.0
8 stars 3 forks source link

callback PlaybackStatusCompat.STATE_ERROR when media not found #67

Closed sjnyag closed 7 years ago

sjnyag commented 7 years ago

FIX #64

Also, you have to increment mCurrentIndex and try to play next music like following.

PlaybackManager.handlePlayRequest() is called not only "when a music is completed and try to play next" but also "when user touches a song on ListView". It's a little confusing if wrong song played when user touches a song on ListView.

And it's much to do above process only "when a music is completed and try to play next".

subaru44k commented 7 years ago

It's a little confusing if wrong song played when user touches a song on ListView.

I agree with your comment.

But, what will happen if a user selects playlist whose first music content is deleted? I guess the user expectation is

Do your modification also work for above case?

sjnyag commented 7 years ago

I agree you but low priority!

subaru44k commented 7 years ago

I understand. Thanks for the consideration.

sjnyag commented 7 years ago

Create new issue #68