Add .clang-format - Githubissues

xslendix commented 4 months ago

Adding a .clang-format file will ensure a consistent coding style is applied across the codebase. This is especially great in fixing some human errors (for example, mixed spaces and tabs in indentation).

xslendix commented 4 months ago

sorry just noticed, will modify title

sjoerdvankreel commented 4 months ago

NP. I will try to commit that "skeleton" implementation somewhere next week. And again thanks for this, it'd be good to finally have core audio support.

sjoerdvankreel commented 4 months ago

@xslendix just saw your additions to the todo-list. Honestly i had no idea you were that well-versed in CoreAudio. I guess, i shouldnt be surprised, seeing you wanted to take on this project in the first place!

I am nearly done with all the "skeleton" stuff (cant promise i will finish today, though), and when done, I will open up a PR, then it's up for you to suggest changes or merge to main.

BTW do you have discord? Or anything more "chatty" than github?

xslendix commented 4 months ago

I'm really not I just looked up some stuff on google, the closest I've been doing stuff in macOS has been in my library that emulates and records global input.

sjoerdvankreel commented 4 months ago

@xslendix

Just opened up the PR. It doesn't quite do everything I want, but must of it. I see you are only 1 hour away in time zone, so i figured you'd not need to wait for me to continue.

Core library compiles, links, and produces a .dylib (of around 500kb, which seems ok) on MacOS + Clang
Then, the build script errors out on building the c++ bindings like this: https://stackoverflow.com/questions/19829281/cmake-os-x-failure-ar-no-archive-members-specific. Which seems understandable, as the c++ bindings are header-only. No idea why this is not an issue on win/lin. Might be easily fixable by adding a dummy .cpp file or going with the suggested SO answer.

The mac build script is in build/build-macos.sh. It produces said xt-audio.dylib in dist/core/xt/debug|release. After the cmake error is fixed it should also produce dist/cpp/sample/debug|release/xt-sample. Thats the native driver program we can use to test all of the basic functionality like querying device names, format support, and do some basic stream operation. See https://github.com/sjoerdvankreel/xt-audio/blob/master/src/cpp/sample/Sample.cpp.

sjoerdvankreel / xt-audio

Add .clang-format #28