search

sjorek / macports-php

The repository is for missing PHP-related macports, like “composer”.
https://sjorek.github.io/macports-php/
BSD 2-Clause "Simplified" License
3 stars 1 forks source link

submit your MacPorts-PHP to official ports collection? #2

Open pdvnl opened 6 years ago

pdvnl commented 6 years ago

would to please consider submitting your MacPorts-PHP to official ports collection?

alexkuc commented 3 years ago

Agree to this. Since you already have a working repository, might submit it as an official port.

brandung-sjorek commented 3 years ago

@alexkuc @pdvnl I try to keep this project in sync with it's homebrew-pendant, which would make such a submission more difficult for me to maintain. So due to the lack of (spare-)time, i still can't promise anything. I'll keep this issue open, as a reminder …

alexkuc commented 3 years ago

In a spirit of FOSS, anything we can do to help you with this repository?

yugaego commented 1 year ago

Sorry to nudge.. I'm interested in composer port only and saw this repo mentioned at Macports Trac. (Kudos to the repo owner 👋🏻 .) Am I seeing it correctly no-one had enough time/energy so far to work on pushing such a port upstream? Anyone has plans to do so?

brandung-sjorek commented 1 year ago

@alexkuc @yugaego @pdvnl I see your/the demand for this port (that's why I build it for me). But one must consider the tight integration of my composer-ports with the historically evolved bash-completion (variant), which in turn is provided as separate port here and implemented in https://github.com/sjorek/composer-bash-completion.

The difficulty I see (at least for me) is that I don't want to loose the features of this bash-completion implementation. I'm aware of the “new” builtin (symfony-driven) bash-completion support in composer itself: https://getcomposer.org/doc/03-cli.md#bash-completions And I invested some time to enhance parts of the new bash completion, but still the new bash-completion lacks features from my implementation (which I really use a lot). To make it short - a shift of the (plain) composer-port to the macports-base would be much easier (for me), if composer's builtin bash-completion would be a little bit more sophisticated, because then I could get rid of my implementation, and I would only have to transfer the plain composer-Ports to macports and use its builtin bash-completion only.

See how selfish I am? 😄 Any suggestions?

brandung-sjorek commented 1 year ago

@yugaego FYI: https://trac.macports.org/ticket/42344#comment:6 (and thanks for the hint in to the MacPorts trac-issue).

Maybe I should just take the plunge and shove off some old habits …

yugaego commented 1 year ago

@brandung-sjorek thanks for the quick reply. I understand your concerns. I'm going to touch wider considerations here and post more composer-concentrated ones at Trac later. I hope php port maintainer chimes in there.

a shift of the (plain) composer-port to the macports-base would be much easier (for me), if composer's builtin bash-completion would be a little bit more sophisticated, because then I could get rid of my implementation

As mostly a fish shell built-in completions user, I know nothing about bash-completion port. Is it too great of an obstacle to bring in the changes you need to it? Since it sounds as if you've formulated one of the possible solutions: add those changes you need to bash-completion and push forward with the composer port.

Another possible approach: taking git-flow-bash-completion port as an example, it should be possible to submit a composer-bash-completion port, I think.

Another group of considerations is composer port itself. Accordingly to your domain-knowledge (I'd love to hear php port maintainer on this as well), would it be preferable for it to go under php port umbrella or be maintained as a separate port? After a short digging in, it seems to me a standalone composer-<version> (or php-composer-<version>) port may be a viable option, right? (f.i. I'm looking at wordpress port php dependencies). This way, you could probably also add a variant bash-completions variant to it.

WDYT?

Oh, and I'm fine to input more if extra hands would be needed after design concerns are resolved.

yugaego commented 1 year ago

BTW, I see that php keyword was removed from the Trac ticket. And php port maintainer isn't CCed on it. So this directs rather towards my last suggestion.

ryandesign commented 9 months ago

I see that php keyword was removed from the Trac ticket.

Because php is not one of the keywords the MacPorts project uses in its issue tracker.

And php port maintainer isn't CCed on it.

Right. I did see the ticket ten years ago when I made the first edit to the ticket, but I didn't write any words and there's no reason for me to be Cc'd since I have nothing to contribute. I know nothing about composer.

sjorek commented 8 months ago

@pdvnl @alexkuc @yugaego @ryandesign Just for the record: https://github.com/macports/macports-ports/pull/19471#issuecomment-1937663838