sjrmanning / darkokai

:new_moon: Dark colour theme inspired by monokai with an uninspired name.
MIT License
118 stars 11 forks source link

Use different colour for mu4e-replied-face #5

Closed nanzhong closed 7 years ago

nanzhong commented 7 years ago

First of all awesome theme, ❤️ing it.

The current colours for mu4e's replied and unread faces are the same, and the only way to distinguish is from the weight. This is pretty confusing as it makes you wonder whether you've read/replied to the mail or not.

screen shot 2017-07-12 at 6 29 04 pm

This changes the font face for replied mail to the font-lock-function-name-faces which is green and feels like a good indicator of action that has been completed (I realize that this might be bad from a usability perspective for red/green colour blind people, but I wasn't sure what other colour would work better; happy to take suggestions).

As a side question, if feels a little weird that the font-lock-*-faces are being re-used/inherited from for colouring purposes, would it make sense in the future to create colour based font-faces that can be used as base building blocks instead of these prog specific ones?

sjrmanning commented 7 years ago

Sorry I totally missed this! Thanks so much, appreciate the PR :)