sjrsjz / Dirt-RT

A minecraft path tracing shaderpack for vulkanite mod
GNU General Public License v3.0
39 stars 0 forks source link

Game looks nothing like screenshots. #1

Closed FormulaCarbon closed 6 months ago

FormulaCarbon commented 7 months ago

I tried using both VanillaPBR and Oversized, and neither gave results like the screenshot. I am using vulkanite-modified 0.0.4. What pack was used in the screenshots?

As of now my game is very bright upon loading. It gets better after but is still nowhere near the screenshots. Also, performance is much worse than it should be when utilizing vulkan.

sjrsjz commented 7 months ago

@FormulaCarbon I tested the pack on 1.20.1, it worked well. However, on 1.20.2, you need to load a pack fit your game version like Aequalis-64x

image

Otherwise the normal texture and specular texture won't work or cause weird bugs like incorrect shadow.

Other game version I haven't tested yet, maybe you can tell me your game version, gpu model and screenshots

FormulaCarbon commented 7 months ago

i tried both 1.20.1 and 1.20.2, got same results. I have an rtx 4060 laptop gpu. will test Aequalis-64x pack and send screenshots

FormulaCarbon commented 7 months ago

@sjrsjz here is screenshot on latest version of Aequalis-64x 2024-01-26_21 07 41

sjrsjz commented 7 months ago

@FormulaCarbon which branch did you use

my gpu is 4060laptop too but it has no bug

1.20.2,Aequalis-64x

2024-01-27_11 17 12

FormulaCarbon commented 7 months ago

@sjrsjz I used whatever version of DirtRT was on modrinth. v0.1.1 I believe. I used the latest version of the texturepack. I used iris 1.6.10 and sodium 5.3.0.

sjrsjz commented 7 months ago

I suddenly get the following error: No known conversion to VK type for GL type RG8 (33323).

But it only appears once and i dont know why

sjrsjz commented 7 months ago

@FormulaCarbon I can't reproduce this error, I've tested it on three different computers with rtx 4060 but none of them have this strange problem

FormulaCarbon commented 7 months ago

what version iris and sodium are you using? becuase there are multiple for 1.20.1

sjrsjz commented 7 months ago

same as you

FormulaCarbon commented 7 months ago

hmm

what other mods are you using?

sjrsjz commented 7 months ago

No other extra mods

FormulaCarbon commented 7 months ago

what are your minecraft settings?

sjrsjz commented 7 months ago

version:3578 autoJump:true operatorItemsTab:false autoSuggestions:true chatColors:true chatLinks:true chatLinksPrompt:true enableVsync:true entityShadows:true forceUnicodeFont:false discrete_mouse_scroll:false invertYMouse:false realmsNotifications:true reducedDebugInfo:false showSubtitles:false directionalAudio:false touchscreen:false fullscreen:false bobView:true toggleCrouch:false toggleSprint:false darkMojangStudiosBackground:false hideLightningFlashes:false mouseSensitivity:0.5 fov:0.0 screenEffectScale:1.0 fovEffectScale:1.0 darknessEffectScale:1.0 glintSpeed:0.5 glintStrength:0.75 damageTiltStrength:1.0 highContrast:false narratorHotkey:true gamma:1.0 renderDistance:6 simulationDistance:12 entityDistanceScaling:1.0 guiScale:3 particles:0 maxFps:260 graphicsMode:1 ao:true prioritizeChunkUpdates:0 biomeBlendRadius:2 renderClouds:"true" resourcePacks:["vanilla","fabric","file/Aequalis-64x.zip"] incompatibleResourcePacks:[] lastServer: lang:zh_cn soundDevice:"" chatVisibility:0 chatOpacity:1.0 chatLineSpacing:0.0 textBackgroundOpacity:0.5 backgroundForChatOnly:true hideServerAddress:false advancedItemTooltips:false pauseOnLostFocus:true overrideWidth:0 overrideHeight:0 chatHeightFocused:1.0 chatDelay:0.0 chatHeightUnfocused:0.4375 chatScale:1.0 chatWidth:1.0 notificationDisplayTime:1.0 mipmapLevels:4 useNativeTransport:true mainHand:"right" attackIndicator:1 narrator:0 tutorialStep:none mouseWheelSensitivity:1.0 rawMouseInput:true glDebugVerbosity:1 skipMultiplayerWarning:true skipRealms32bitWarning:false hideMatchedNames:true joinedFirstServer:true hideBundleTutorial:false syncChunkWrites:true showAutosaveIndicator:true allowServerListing:true onlyShowSecureChat:false panoramaScrollSpeed:1.0 telemetryOptInExtra:false onboardAccessibility:false key_key.attack:key.mouse.left key_key.use:key.mouse.right key_key.forward:key.keyboard.w key_key.left:key.keyboard.a key_key.back:key.keyboard.s key_key.right:key.keyboard.d key_key.jump:key.keyboard.space key_key.sneak:key.keyboard.left.shift key_key.sprint:key.keyboard.left.control key_key.drop:key.keyboard.q key_key.inventory:key.keyboard.e key_key.chat:key.keyboard.t key_key.playerlist:key.keyboard.tab key_key.pickItem:key.mouse.middle key_key.command:key.keyboard.slash key_key.socialInteractions:key.keyboard.p key_key.screenshot:key.keyboard.f2 key_key.togglePerspective:key.keyboard.f5 key_key.smoothCamera:key.keyboard.unknown key_key.fullscreen:key.keyboard.f11 key_key.spectatorOutlines:key.keyboard.unknown key_key.swapOffhand:key.keyboard.f key_key.saveToolbarActivator:key.keyboard.c key_key.loadToolbarActivator:key.keyboard.x key_key.advancements:key.keyboard.l key_key.hotbar.1:key.keyboard.1 key_key.hotbar.2:key.keyboard.2 key_key.hotbar.3:key.keyboard.3 key_key.hotbar.4:key.keyboard.4 key_key.hotbar.5:key.keyboard.5 key_key.hotbar.6:key.keyboard.6 key_key.hotbar.7:key.keyboard.7 key_key.hotbar.8:key.keyboard.8 key_key.hotbar.9:key.keyboard.9 key_iris.keybind.reload:key.keyboard.r key_iris.keybind.toggleShaders:key.keyboard.k key_iris.keybind.shaderPackSelection:key.keyboard.o soundCategory_master:1.0 soundCategory_music:0.01443661971830984 soundCategory_record:1.0 soundCategory_weather:1.0 soundCategory_block:1.0 soundCategory_hostile:1.0 soundCategory_neutral:1.0 soundCategory_player:1.0 soundCategory_ambient:1.0 soundCategory_voice:1.0 modelPart_cape:true modelPart_jacket:true modelPart_left_sleeve:true modelPart_right_sleeve:true modelPart_left_pants_leg:true modelPart_right_pants_leg:true modelPart_hat:true

sjrsjz commented 7 months ago

@FormulaCarbon I reproduced the bug. it could be caused by the driver version, as the error was generated after I upgraded to the latest NVIDIA driver

2024-02-06_19 48 01

FormulaCarbon commented 7 months ago

Ah, ok. Can that be fixed in the shader or do we just need to wait for next update?

sjrsjz commented 7 months ago

This seems to be a nasty bug in the shader compiler, where a serious error occurs in the passing of a certain struct parameter. I have now found an alternative solution

FormulaCarbon commented 7 months ago

Already found a solution? That was fast.

sjrsjz commented 7 months ago

Maybe just passing the structure members separately would fix the problem

FormulaCarbon commented 7 months ago

Oh are you saying that a struct is not being interpreted properly or something?

sjrsjz commented 7 months ago

The data in the structure parameter seems to cause floating-point calculation errors

However there is nothing wrong with the parameters I passed in, it could only be a compiler error

FormulaCarbon commented 7 months ago

I’m looking at the changelog for version 551.23. First thing I see is HDR stuff and ultra-low-latency for directx12 games.

FormulaCarbon commented 7 months ago

I think I found it image

FormulaCarbon commented 7 months ago

This is under vulkan-interop stuff by the way.

FormulaCarbon commented 7 months ago

https://us.download.nvidia.com/Windows/551.23/551.23-win11-win10-release-notes.pdf Here is link Vulkan interoperability stuff starts at 2.6

sjrsjz commented 7 months ago

oh thanks

sjrsjz commented 7 months ago

Fixed!

FormulaCarbon commented 7 months ago

Nice! I will try on my system when I get home.

FormulaCarbon commented 7 months ago

looks good but fps isnt very high. How much fps do you get and whats ur system?

sjrsjz commented 7 months ago

about 30fps at 720p, optimization is very bad

sjrsjz commented 7 months ago

This is my first real-time rendering project.