search

sjrusso8 / spark-connect-rs

Apache Spark Connect Client for Rust
https://docs.rs/spark-connect-rs
Apache License 2.0
52 stars 11 forks source link

#[allow(non_snake_case)] #36

Closed abrassel closed 2 weeks ago

abrassel commented 1 month ago

Hi @sjrusso8 can you tell me the rationale behind exposing a camel cased API?

Seems like we should be fine just using idiomatic rust snake casing.

On a separate note, do you have an IM channel of some kind to chat about this project? I would love to iterate more rapidly with you.

sjrusso8 commented 1 month ago

The only rationale was to match the existing API naming so that someone who is use to using scala or python could easily use the rust client crate. No other real reason :)

I’ll send you a message on slack.

wvwwvwwv commented 3 weeks ago

Hi! As a software developer who has experience in both spark-connect and Rust, I would prefer disallowing non_snake_cases in Rust code, because people who try to use this library are most likely knowledgeable about Rust and more comfortable with idiomatic Rust code.

sjrusso8 commented 3 weeks ago

I've been thinking about it a lot and arrived at that same conclusion. Rust users would be expecting rust idiomatic code, not spark code. I can work on switching these around.