search

sjsadowski / firewalld-cookbook

Chef recipe to manage Linux firewalld ports
https://supermarket.chef.io/cookbooks/firewalld
Apache License 2.0
20 stars 23 forks source link

The limit description is deceptive #13

Open sspans opened 9 years ago

sspans commented 9 years ago

The limit directive in firewalld can either be used to limit logging - or - to limit matches. The default in resources/rich_rule.rb disables logging, but enables the limit. This results in rules like:

-A IN_admin_allow -p tcp -m tcp --dport 5666 -m conntrack --ctstate NEW -m limit --limit 1/min -j ACCEPT

Not quite what I was expecting.

sspans commented 9 years ago

Secondly, it doesn't seem to be possible to unset the limit_value...

gene1wood commented 8 years ago

@sspans has a PR for this in PR #14

ghost commented 8 years ago

Could this PR get integrated into master and the version bumped please?

I ran up against this yesterday.

gene1wood commented 8 years ago

@carljohnston1 you may want to comment in PR #14 instead of this issue.

sjsadowski commented 8 years ago

Just found this today; somewhat obnoxious - please get this implemented, bumped, and released.

sjsadowski commented 8 years ago

Just created a pull request to bring the recipe in line with the docs.

gene1wood commented 8 years ago

sjsadowski is referring to PR #18

sjsadowski commented 8 years ago

This should probably be closed now that my PR is merged in

gene1wood commented 7 years ago

@rigrassm Would you close this issue as it was resolved with your merge of #18